[stable30] feat(Call): show presenter overlay for local screenshare (+ dev fixes) #13547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
3. to review
technical debt
feature: frontend 🖌️
Antreesy
force-pushed
the
backport/13026/stable30
branch
from
a4ba108 to
2220165
Compare
Antreesy
approved these changes
Oct 14, 2024
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Tested:
- devMode, screenshotMode
- presenterOverlay on local screenshare
- promoted view fix
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]> (cherry picked from commit 6508165)
Signed-off-by: Maksim Sukharev <[email protected]> (cherry picked from commit e9cb24d)
Signed-off-by: Maksim Sukharev <[email protected]> (cherry picked from commit 312297a)
Signed-off-by: DorraJaouad <[email protected]> (cherry picked from commit 6a88cbc)
Signed-off-by: DorraJaouad <[email protected]> (cherry picked from commit 9631f94)
Signed-off-by: Antreesy <[email protected]> (cherry picked from commit 0b67e32)
- for main branch only Signed-off-by: Maksim Sukharev <[email protected]> (cherry picked from commit a5fea11)
- PresenterOverlay broke v-else-if flow in previous place - also add distinct keys to prevent rendering issues Signed-off-by: Maksim Sukharev <[email protected]> (cherry picked from commit fe49e77)
Antreesy
force-pushed
the
backport/13026/stable30
branch
from
2220165 to
bf63dc8
Compare
Antreesy
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of:
Warning, This backport's changes differ from the original and might be incomplete⚠️
Further backporting is always a mess
Todo